Skip to content

Update Claude Code action to restrict package permissions and remove …#656

Merged
MervinPraison merged 1 commit intomainfrom
develop
Jun 16, 2025
Merged

Update Claude Code action to restrict package permissions and remove …#656
MervinPraison merged 1 commit intomainfrom
develop

Conversation

@MervinPraison
Copy link
Copy Markdown
Owner

@MervinPraison MervinPraison commented Jun 16, 2025

User description

…Docker image build step for streamlined workflow.


PR Type

Enhancement


Description

• Separate Docker image build into dedicated workflow
• Restrict Claude workflow package permissions to read-only
• Remove Docker build steps from main Claude workflow
• Add manual trigger for image building with version input


Changes walkthrough 📝

Relevant files
Enhancement
build-image.yml
Add dedicated Docker image build workflow                               

.github/workflows/build-image.yml

• Add new workflow for building Claude Code Docker image
• Include
manual trigger with version input parameter
• Configure GitHub
Container Registry authentication and push
• Set up Docker Buildx with
caching optimization

+39/-0   
claude.yml
Streamline Claude workflow and restrict permissions           

.github/workflows/claude.yml

• Change package permissions from write to read-only
• Remove Docker
Buildx setup step
• Remove Docker build and push step
• Keep GitHub
Container Registry login for image pulling

+1/-13   

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Summary by CodeRabbit

    • Chores
      • Introduced a new workflow for manually building and publishing Docker images to the GitHub Container Registry.
      • Updated an existing workflow to remove image build and push steps, and reduced package permissions to read-only.

    …Docker image build step for streamlined workflow.
    @gemini-code-assist
    Copy link
    Copy Markdown
    Contributor

    Note

    Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

    @coderabbitai
    Copy link
    Copy Markdown
    Contributor

    coderabbitai bot commented Jun 16, 2025

    Warning

    Rate limit exceeded

    @qodo-merge-pro[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 10 seconds before requesting another review.

    ⌛ How to resolve this issue?

    After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

    We recommend that you space out your commits to avoid hitting the rate limit.

    🚦 How do rate limits work?

    CodeRabbit enforces hourly rate limits for each developer per organization.

    Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

    Please see our FAQ for further information.

    📥 Commits

    Reviewing files that changed from the base of the PR and between 85c4bac and 866920c.

    📒 Files selected for processing (2)
    • .github/workflows/build-image.yml (1 hunks)
    • .github/workflows/claude.yml (1 hunks)

    Walkthrough

    A new GitHub Actions workflow for building and pushing a Docker image was added. The existing Claude workflow was simplified by removing Docker build and push steps, downgrading package permissions, and now only checks out the repository, logs in to the registry, and runs the action without rebuilding the image.

    Changes

    File(s) Change Summary
    .github/workflows/build-image.yml Added workflow to build and push Docker image for Claude Code action to GitHub Container Registry
    .github/workflows/claude.yml Removed Docker build/push steps, downgraded permissions, now only runs action using prebuilt image

    Sequence Diagram(s)

    sequenceDiagram
        participant User as User
        participant GitHub Actions as GitHub Actions
        participant Docker Registry as GitHub Container Registry
    
        User->>GitHub Actions: Trigger build-image workflow (manual)
        GitHub Actions->>GitHub Actions: Checkout repo, setup Docker Buildx
        GitHub Actions->>Docker Registry: Login
        GitHub Actions->>Docker Registry: Build & push Docker image
    
        User->>GitHub Actions: Trigger claude workflow
        GitHub Actions->>GitHub Actions: Checkout repo
        GitHub Actions->>Docker Registry: Login
        GitHub Actions->>GitHub Actions: Run claude-code-action using prebuilt image
    
    Loading

    Possibly related PRs

    Suggested labels

    Review effort 2/5

    Poem

    A Docker image built with care,
    Now pushed with workflows, light as air.
    Claude’s code runs swift and clean,
    With builds and pushes kept unseen.
    Actions simplified, permissions tight—
    The rabbit hops with pure delight! 🐇✨


    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share
    🪧 Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>, please review it.
      • Explain this complex logic.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai explain this code block.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
      • @coderabbitai read src/utils.ts and explain its main purpose.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
      • @coderabbitai help me debug CodeRabbit configuration file.

    Support

    Need help? Create a ticket on our support page for assistance with any issues or questions.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (Invoked using PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai full review to do a full review from scratch and review all the files again.
    • @coderabbitai summary to regenerate the summary of the PR.
    • @coderabbitai generate docstrings to generate docstrings for this PR.
    • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
    • @coderabbitai help to get help.

    Other keywords and placeholders

    • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
    • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
    • Add @coderabbitai anywhere in the PR title to generate the title automatically.

    CodeRabbit Configuration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    @MervinPraison MervinPraison merged commit 4f7d7d1 into main Jun 16, 2025
    3 of 13 checks passed
    @qodo-code-review
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Permission Mismatch

    The workflow still includes Docker login step but changed packages permission from write to read. If the Claude action needs to pull Docker images, this should work, but if it needs to push or the login is unnecessary, this step should be removed for security.

    - name: Login to GitHub Container Registry
      uses: docker/login-action@v3
      with:
        registry: ghcr.io
        username: ${{ github.actor }}
        password: ${{ secrets.GITHUB_TOKEN }}
    Hardcoded Registry

    The Docker image tag uses a hardcoded registry path 'ghcr.io/mervinpraison/praisonai-claudecode' which may not be portable across different repositories or organizations.

    tags: ghcr.io/mervinpraison/praisonai-claudecode:${{ inputs.version }}
    cache-from: type=gha

    @qodo-code-review
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Security
    Enable provenance attestation for security

    The provenance: false setting disables SLSA provenance attestation which reduces
    supply chain security. Consider removing this line to enable provenance
    generation unless there's a specific compatibility requirement.

    .github/workflows/build-image.yml [31-39]

     - name: Build and push Docker image
       uses: docker/build-push-action@v5
       with:
         context: ./.github/actions/claude-code-action
         push: true
         tags: ghcr.io/mervinpraison/praisonai-claudecode:${{ inputs.version }}
         cache-from: type=gha
         cache-to: type=gha,mode=max
    -    provenance: false
    • Apply / Chat
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly points out a significant security concern. Disabling SLSA provenance by setting provenance: false reduces supply chain security. Enabling it is a critical best practice, and the suggestion provides a clear and correct way to fix it.

    High
    • More

    shaneholloman pushed a commit to shaneholloman/praisonai that referenced this pull request Feb 4, 2026
    Update Claude Code action to restrict package permissions and remove …
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant